arjun4084346 commented on code in PR #3955:
URL: https://github.com/apache/gobblin/pull/3955#discussion_r1623096103
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/ManifestBasedDataset.java:
##########
@@ -132,9 +132,10 @@ public Iterator<FileSet<CopyEntity>>
getFileSetIterator(FileSystem targetFs, Cop
copyableFile.setFsDatasets(srcFs, targetFs);
copyEntities.add(copyableFile);
- Path fromPath = srcFs.getFileStatus(fileToCopy).isDirectory() ?
fileToCopy : fileToCopy.getParent();
+ // Always grab the parent since the above permission setting
should be setting the permission for a folder itself
Review Comment:
can you add to the comment more details why we need/can skip the last dir,
and also comment about these permissions being set in other place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
