[
https://issues.apache.org/jira/browse/GOBBLIN-2078?focusedWorklogId=921891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-921891
]
ASF GitHub Bot logged work on GOBBLIN-2078:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/24 04:39
Start Date: 04/Jun/24 04:39
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3961:
URL: https://github.com/apache/gobblin/pull/3961#discussion_r1625333466
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/troubleshooter/AutomaticTroubleshooterFactory.java:
##########
@@ -37,10 +37,10 @@ public class AutomaticTroubleshooterFactory {
* If this module is missing, troubleshooter will default to a no-op
implementation.
*
* In addition, even when the "gobblin-troubleshooter" module is present,
troubleshooter can still be disabled
- * with {@link ConfigurationKeys.TROUBLESHOOTER_DISABLED} setting.
+ * with {@link ConfigurationKeys#TROUBLESHOOTER_DISABLED} setting.
* */
- public static AutomaticTroubleshooter createForJob(Config config) {
- AutomaticTroubleshooterConfig troubleshooterConfig = new
AutomaticTroubleshooterConfig(config);
+ public static AutomaticTroubleshooter createForJob(Properties properties) {
+ AutomaticTroubleshooterConfig troubleshooterConfig = new
AutomaticTroubleshooterConfig(properties);
Review Comment:
next time when making a change to a public API to fix a completely
unanticipated runtime error, please add documentation to the actual source code
about what condition must being prevented and how.
e.g. this might live in this javadoc or that of
`AutomaticTroubleshooterConfig` (less preferred)
Issue Time Tracking
-------------------
Worklog Id: (was: 921891)
Time Spent: 20m (was: 10m)
> remove use of typesafe config because they may have a config that is prefix
> of another config
> ---------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2078
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2078
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
