phet commented on code in PR #3965:
URL: https://github.com/apache/gobblin/pull/3965#discussion_r1635637283
##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -77,6 +79,7 @@ class TestMetastoreDatabaseServer implements Closeable {
private final String dbUserPassword;
private final String dbHost;
private final int dbPort;
+ private static Map<String, Injector> injectors = new HashMap<>();
Review Comment:
I don't understand who's using this. is it basically a per-JDBC-URI mapping
that caches the `Injector`, so it's not created multiple times? a comment
would help here, esp. if there's some nuance as to how caching helps
if so, should this method either be synchronized or we use
`ConcurrentHashMap`?
also, naming could be clearer, such as `injectorsByJdbcUri`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
