[
https://issues.apache.org/jira/browse/GOBBLIN-2085?focusedWorklogId=923166&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923166
]
ASF GitHub Bot logged work on GOBBLIN-2085:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/24 18:26
Start Date: 12/Jun/24 18:26
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #3970:
URL: https://github.com/apache/gobblin/pull/3970#issuecomment-2163659923
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/3970?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `0%` with `3 lines` in your changes missing
coverage. Please review.
> Project coverage is 41.00%. Comparing base
[(`227f39b`)](https://app.codecov.io/gh/apache/gobblin/commit/227f39b0740d85b07e95f2fa87e7bcf0c834c5da?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`ed32cc0`)](https://app.codecov.io/gh/apache/gobblin/commit/ed32cc0f18bf6d4085b13199703fcbcf53f82b30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
|
[Files](https://app.codecov.io/gh/apache/gobblin/pull/3970?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...oral/ddm/workflow/impl/CommitStepWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FCommitStepWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9Db21taXRTdGVwV29ya2Zsb3dJbXBsLmphdmE=)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FExecuteGobblinWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9FeGVjdXRlR29iYmxpbldvcmtmbG93SW1wbC5qYXZh)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...impl/NestingExecOfProcessWorkUnitWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FNestingExecOfProcessWorkUnitWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9OZXN0aW5nRXhlY09mUHJvY2Vzc1dvcmtVbml0V29ya2Zsb3dJbXBsLmphdmE=)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/3970?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3970 +/- ##
=============================================
- Coverage 54.80% 41.00% -13.80%
- Complexity 1608 2187 +579
=============================================
Files 316 478 +162
Lines 11516 20264 +8748
Branches 1204 2344 +1140
=============================================
+ Hits 6311 8310 +1999
- Misses 4629 11063 +6434
- Partials 576 891 +315
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/3970?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 923166)
Time Spent: 20m (was: 10m)
> Increase `startToCloseTimeout` for `ExecuteGobblinWorkflow` activities
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-2085
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2085
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> the currently hard-coded `startToCloseTimeout` values are too short.
> requirements that have come to light w/ operational experience:
> * `ProcessWorkUnits` must support extractors utilizing little parallelism
> (such as those reading from a DB) that take a very long time, even upwards of
> hours
> * `CommitActivity` runs may have to handle O(10k) or more task state files,
> which may take a long time to open and read, esp. when the `FileSystem` is
> under heavy load
> * `GenerateWorkUnits` must work with sources that may be quite vast, yet w/
> limited recourse to parallelism, such as a massive source iceberg
> ultimately these and other temporal config values would ideally be
> configurable, and that will come soon. for now, just bump to values large
> enough to resolve site-up issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
