[
https://issues.apache.org/jira/browse/GOBBLIN-2086?focusedWorklogId=923173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923173
]
ASF GitHub Bot logged work on GOBBLIN-2086:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/24 19:37
Start Date: 12/Jun/24 19:37
Worklog Time Spent: 10m
Work Description: umustafi opened a new pull request, #3971:
URL: https://github.com/apache/gobblin/pull/3971
…cheduler
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2086
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
An ObjectAlreadyExistsException is thrown by the QuartzScheduler for
deadline dagAction types when attempting to set a reminder on the lease of a
deadline dagAction type because the original (non-reminder) job may still exist
in the DagActionReminderScheduler. It's a non-fatal exception to have redundant
reminders on the same dagAction so the code change gracefully handles this
problem.
Exception:
Unable to store Job :
'[flowgroup].[flowname].[flowid].ENFORCE_JOB_START_DEADLINE', because one
already exists with this
identification.","stackTrace":[{"index":0,"call":"storeJob","columnNumber":null,"fileName":"RAMJobStore.java","lineNumber":279,"nativeMethod":"0","source":"org.quartz.simpl.RAMJobStore"},{"index":1,"call":"storeJobAndTrigger",
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
- Updates test to verify jobs are not durably stored (orphaned jobs, or
those without triggers, are deleted)
- Adds test to validate no error thrown for job with multiple reminders
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 923173)
Remaining Estimate: 0h
Time Spent: 10m
> Allow multiple reminders for the same dagAction in DagActionReminderScheduler
> -----------------------------------------------------------------------------
>
> Key: GOBBLIN-2086
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2086
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> An ObjectAlreadyExistsException is thrown by the QuartzScheduler for deadline
> dagAction types when attempting to set a reminder on the lease of a deadline
> dagAction type because the original (non-reminder) job may still exist in the
> DagActionReminderScheduler. It's a non-fatal exception to have redundant
> reminders on the same dagAction so the code change gracefully handles this
> problem.
>
> Exception:
> Unable to store Job :
> '[flowgroup].[flowname].[flowid].ENFORCE_JOB_START_DEADLINE', because one
> already exists with this
> identification.","stackTrace":[\{"index":0,"call":"storeJob","columnNumber":null,"fileName":"RAMJobStore.java","lineNumber":279,"nativeMethod":"0","source":"org.quartz.simpl.RAMJobStore"},{"index":1,"call":"storeJobAndTrigger",
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
