arjun4084346 commented on code in PR #3971:
URL: https://github.com/apache/gobblin/pull/3971#discussion_r1637040873
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -68,7 +68,12 @@ public void scheduleReminder(DagActionStore.DagAction
dagAction, long reminderDu
throws SchedulerException {
JobDetail jobDetail = createReminderJobDetail(dagAction);
Trigger trigger = createReminderJobTrigger(dagAction,
reminderDurationMillis, System::currentTimeMillis);
- quartzScheduler.scheduleJob(jobDetail, trigger);
+ /* Add the job to the scheduler if it doesn't already exist. Note the job
already exists for the true reminders of
+ dag actions of type ENFORCE_JOB_START_DEADLINE and
ENFORCE_FLOW_FINISH_DEADLINE because the original (non-reminder)
+ actions are added to the scheduler to notify the hosts when the deadlines
have passed.
+ */
+ quartzScheduler.addJob(jobDetail, true);
Review Comment:
java doc says, "The Job must by definition be 'durable', if it is not,
SchedulerException will be thrown."
the job is not durable. then why the unit test is not throwing exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
