pawanbtej opened a new pull request, #3972: URL: https://github.com/apache/gobblin/pull/3972
Addressed the limitation where the database name had to be extracted from the pattern by adding support for an optional database name in the DatasetHiveSchemaContainsNonOptionalUnion class. Issue with the current approach: - The database name had to be extracted from the dataset URN using a regex pattern, which limited flexibility and could lead to errors if the URN format changed. Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [GOBBLIN-2087](https://issues.apache.org/jira/browse/GOBBLIN-2087) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description Changes made: - Added a new property `OPTIONAL_DB_NAME` for specifying an optional database name. - Updated the constructor and methods to check for and use the optional database name if provided. - Added logging to indicate when the optional database name is used and replaced the pattern-extracted database name. - Ensured backward compatibility by retaining the existing behavior when the optional database name is not provided. These changes enhance the flexibility and usability of the DatasetHiveSchemaContainsNonOptionalUnion class, allowing for more dynamic database configurations and reducing dependency on the dataset URN format. ### Tests - [ ] a new test case to verify the behavior with the optional database name: - `testContainsNonOptionalUnionWithOptionalDbName`: Verifies that the optional database name is correctly used and replaces the pattern-extracted database name. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
