[
https://issues.apache.org/jira/browse/GOBBLIN-2073?focusedWorklogId=923565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923565
]
ASF GitHub Bot logged work on GOBBLIN-2073:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/24 19:24
Start Date: 14/Jun/24 19:24
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #3952:
URL: https://github.com/apache/gobblin/pull/3952#discussion_r1640250213
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagement.java:
##########
@@ -27,5 +27,13 @@
*/
public interface DagManagement {
+ /**
+ * Used to add a dagAction event to DagManagement
+ */
void addDagAction(DagActionStore.DagAction dagAction) throws IOException;
+
+ /**
+ * Used to add reminder dagActions to the queue that already contain an
eventTimestamp from the previous lease attempt
+ */
+ void addDagAction(DagActionStore.LeaseObject reminderDagActionLeaseObject)
throws IOException;
Review Comment:
Shouldn't it be named just `dagActionLeaseObject`. If it is always a
reminder, then a) why `LeaseObject` has `isReminder` field, b) method's name
should be addReminderDagAction, right?
Issue Time Tracking
-------------------
Worklog Id: (was: 923565)
Time Spent: 3h (was: 2h 50m)
> Add eventTime and reminder fields to DagAction POJO
> ---------------------------------------------------
>
> Key: GOBBLIN-2073
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2073
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> An event timestamp and reminder flag are used in conjunction with DagActions
> for lease arbitration and for reminder dagActions. It makes sense to include
> these fields in the DagAction object itself to easily transfer the
> information from one location to another. In particular for reminder events
> used to check back in on incomplete dagAction leases, these two fields are
> utilized and it's easiest to keep track of them when it's maintained within
> the consensusDagAction returned in a LeaseAttemptStatus
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
