pratapaditya04 commented on code in PR #3986:
URL: https://github.com/apache/gobblin/pull/3986#discussion_r1653298786
##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -83,10 +83,10 @@ class TestMetastoreDatabaseServer implements Closeable {
if (this.embeddedMysqlEnabled) {
mySQLContainer = new MySQLContainer<>("mysql:" + MYSQL_VERSION)
.withUsername(this.dbUserName)
- .withPassword(this.dbUserPassword)
- .withEnv(MYSQL_ROOT_PASSWORD, "");
-
+ .withPassword(this.dbUserPassword);
mySQLContainer.start();
+ mySQLContainer.withEnv(MYSQL_ROOT_PASSWORD_KEY, ROOT_PASSWORD);
Review Comment:
No, the tests are running in local , only failing in CI pipeline because the
root password in github actions is different than the user password. Actually,
I guess, mysqlcontainer is not allowing the root password to be different than
the user password. Have changed the root password in github action to be same
as user. Have updated the PR
if (this.password != null && !this.password.isEmpty()) {
this.addEnv("MYSQL_PASSWORD", this.password);
this.addEnv("MYSQL_ROOT_PASSWORD", this.password);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
