[
https://issues.apache.org/jira/browse/GOBBLIN-2098?focusedWorklogId=924173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924173
]
ASF GitHub Bot logged work on GOBBLIN-2098:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/24 16:56
Start Date: 02/Jul/24 16:56
Worklog Time Spent: 10m
Work Description: Will-Lo commented on code in PR #3986:
URL: https://github.com/apache/gobblin/pull/3986#discussion_r1653279236
##########
gobblin-metastore/src/test/java/org/apache/gobblin/metastore/testing/TestMetastoreDatabaseServer.java:
##########
@@ -83,10 +83,10 @@ class TestMetastoreDatabaseServer implements Closeable {
if (this.embeddedMysqlEnabled) {
mySQLContainer = new MySQLContainer<>("mysql:" + MYSQL_VERSION)
.withUsername(this.dbUserName)
- .withPassword(this.dbUserPassword)
- .withEnv(MYSQL_ROOT_PASSWORD, "");
-
+ .withPassword(this.dbUserPassword);
mySQLContainer.start();
+ mySQLContainer.withEnv(MYSQL_ROOT_PASSWORD_KEY, ROOT_PASSWORD);
Review Comment:
You may need to be defining this before running `.start()`
Issue Time Tracking
-------------------
Worklog Id: (was: 924173)
Remaining Estimate: 0h
Time Spent: 10m
> Updating the test Mysql version, and getting rid of
> com.wix:wix-embedded-mysql(deprected) in favour of org.testcontainers
> -------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2098
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2098
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Updating the test Mysql version, and getting rid of
> com.wix:wix-embedded-mysql(deprected) in favour of org.testcontainers
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
