[
https://issues.apache.org/jira/browse/GOBBLIN-2016?focusedWorklogId=924896&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924896
]
ASF GitHub Bot logged work on GOBBLIN-2016:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jul/24 20:53
Start Date: 08/Jul/24 20:53
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #3995:
URL: https://github.com/apache/gobblin/pull/3995#discussion_r1669297319
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -128,23 +128,27 @@ public void execute(JobExecutionContext context) {
}
/**
- * Creates a key for the reminder job by concatenating all dagAction fields
+ * Creates a key for the reminder job by concatenating all dagAction fields
and the eventTime of the dagAction to
+ * allow reminders for actions associated with multiple flow executions
within a deadline period (e.g. another
+ * flow execution may occur before a flow finish or job start deadline
expires)
Review Comment:
this doesn't capture the nuance of why incorporate the flowExecId into the
key is insufficient and an event timestamp is needed in addition.
please explain... (doesn't it have to do w/ event consolidation?)
Issue Time Tracking
-------------------
Worklog Id: (was: 924896)
Time Spent: 40m (was: 0.5h)
> retry retry-able exceptions in DagProcs
> ---------------------------------------
>
> Key: GOBBLIN-2016
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2016
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
