umustafi commented on code in PR #3994:
URL: https://github.com/apache/gobblin/pull/3994#discussion_r1669439540
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionReminderScheduler.java:
##########
@@ -77,28 +95,45 @@ public DagActionReminderScheduler(StdSchedulerFactory
schedulerFactory)
* @throws SchedulerException
*/
public void scheduleReminder(DagActionStore.LeaseParams leaseParams, long
reminderDurationMillis,
- boolean isDeadlineReminder)
- throws SchedulerException {
+ boolean isDeadlineReminder) throws SchedulerException {
+ DagActionStore.DagAction dagAction = leaseParams.getDagAction();
JobDetail jobDetail = createReminderJobDetail(leaseParams,
isDeadlineReminder);
- Trigger trigger = createReminderJobTrigger(leaseParams.getDagAction(),
reminderDurationMillis,
+ Trigger trigger = createReminderJobTrigger(dagAction,
reminderDurationMillis,
System::currentTimeMillis, isDeadlineReminder);
- log.info("Reminder set for dagAction {} to fire after {} ms,
isDeadlineTrigger: {}",
- leaseParams.getDagAction(), reminderDurationMillis,
isDeadlineReminder);
- quartzScheduler.scheduleJob(jobDetail, trigger);
+ log.info("Going to set reminder for dagAction {} to fire after {} ms,
isDeadlineTrigger: {}",
+ dagAction, reminderDurationMillis, isDeadlineReminder);
+
+ try {
+ if (!this.deleteDeadlineDagActionCache.get(dagAction)) {
+ quartzScheduler.scheduleJob(jobDetail, trigger);
+ } else {
+ log.info("Ignoring {} because the delete equivalent of the same
received already.", dagAction);
Review Comment:
`DagActionReminderScheduler` skipping adding reminder for action because
already received delete for this action: {}.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
