[
https://issues.apache.org/jira/browse/GOBBLIN-2107?focusedWorklogId=925308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925308
]
ASF GitHub Bot logged work on GOBBLIN-2107:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/24 18:47
Start Date: 10/Jul/24 18:47
Worklog Time Spent: 10m
Work Description: umustafi commented on PR #3996:
URL: https://github.com/apache/gobblin/pull/3996#issuecomment-2221204478
> Are we not including this function in the DagProcEngine as well? Or is
that out of scope
Good call out. I'm going to put that as out of scope, @arjun4084346 or I
will add this in separate PR for `DagProcessingEngine`
Issue Time Tracking
-------------------
Worklog Id: (was: 925308)
Time Spent: 1h 50m (was: 1h 40m)
> Delete adhoc flowSpecs from flowCatalog
> ----------------------------------------
>
> Key: GOBBLIN-2107
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2107
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Delete adhoc flowSpecs from flowCatalog to avoid build up of adhoc flowSpecs
> in catalog even when job compilation fails by adding the deletion in a
> finally block in non-MA scheduler case.
> # Previous PR: [https://github.com/apache/gobblin/pull/3944/files] causes a
> bug where adhoc flows are not deleted when multi-active scheduler is enabled.
> This PR re-adds deletion of flowSpec to the dagManager to be called by the
> active host for the MA scheduler case (there will only be one active host if
> dagManager is enabled otherwise code will use dagProcessingEngine).
> # It also ensures quota is released and failed flow compilation event sent
> by the FlowCompilationValidationHelper in all compilation failure cases. This
> was being incorrectly handled before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
