Will-Lo commented on code in PR #4004:
URL: https://github.com/apache/gobblin/pull/4004#discussion_r1680136542
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -112,20 +112,26 @@ public Optional<Dag<JobExecutionPlan>>
createExecutionPlanIfValid(FlowSpec flowS
TimingEvent flowCompilationTimer = new TimingEvent(this.eventSubmitter,
TimingEvent.FlowTimings.FLOW_COMPILED);
Map<String, String> flowMetadata =
TimingEventUtils.getFlowMetadata(flowSpec);
- Optional<Dag<JobExecutionPlan>> jobExecutionPlanDagOptional =
- validateAndHandleConcurrentExecution(flowConfig, flowSpec, flowGroup,
flowName, flowMetadata);
- if (!jobExecutionPlanDagOptional.isPresent()) {
- return Optional.absent();
- }
+ try {
+ Optional<Dag<JobExecutionPlan>> jobExecutionPlanDagOptional =
+ validateAndHandleConcurrentExecution(flowConfig, flowSpec,
flowGroup, flowName, flowMetadata);
- if (jobExecutionPlanDagOptional.get().isEmpty()) {
- populateFlowCompilationFailedEventMessage(eventSubmitter, flowSpec,
flowMetadata);
- return Optional.absent();
- }
+ if (!jobExecutionPlanDagOptional.isPresent()) {
+ return Optional.absent();
+ }
+
+ if (jobExecutionPlanDagOptional.get().isEmpty()) {
+ populateFlowCompilationFailedEventMessage(eventSubmitter, flowSpec,
flowMetadata);
+ return Optional.absent();
+ }
- flowCompilationTimer.stop(flowMetadata);
- return jobExecutionPlanDagOptional;
+ flowCompilationTimer.stop(flowMetadata);
+ return jobExecutionPlanDagOptional;
+ } catch (IOException e) {
+ log.error("Encountered exception when attempting to compile and perform
checks for flow: {}", flowSpec);
Review Comment:
If you want to log this out maybe only print out the flowspec IDs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
