[
https://issues.apache.org/jira/browse/GOBBLIN-2104?focusedWorklogId=926258&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926258
]
ASF GitHub Bot logged work on GOBBLIN-2104:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/24 23:48
Start Date: 16/Jul/24 23:48
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1680180553
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -63,13 +64,16 @@ public DagProc(DagTask dagTask) {
this.dagNodeId = this.dagTask.getDagAction().getDagNodeId();
}
- public final void process(DagManagementStateStore dagManagementStateStore)
throws IOException {
- T state = initialize(dagManagementStateStore); // todo - retry
- act(dagManagementStateStore, state); // todo - retry
+ public final void process(DagManagementStateStore dagManagementStateStore,
+ DagProcessingEngineMetrics dagProcEngineMetrics) throws IOException {
+ T state = initialize(dagManagementStateStore, dagProcEngineMetrics); //
todo - retry
+ act(dagManagementStateStore, state, dagProcEngineMetrics); // todo -
retry
Review Comment:
I wrapped the calls for `initialize` since it's a relatively simple
function, but `act` would be a little more complicated because there are
multiple points of failure. I would have to change the API to return a boolean
perhaps indicating whether or not `act` was successful because there are
failure cases that do not result in an exception being thrown.
Issue Time Tracking
-------------------
Worklog Id: (was: 926258)
Time Spent: 1.5h (was: 1h 20m)
> Initialize DagProcessingEngine Metrics
> --------------------------------------
>
> Key: GOBBLIN-2104
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2104
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
