arjun4084346 commented on code in PR #4002:
URL: https://github.com/apache/gobblin/pull/4002#discussion_r1680300699
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/LaunchDagProc.java:
##########
@@ -69,6 +69,10 @@ protected Optional<Dag<JobExecutionPlan>>
initialize(DagManagementStateStore dag
Optional<Dag<JobExecutionPlan>> dag =
this.flowCompilationValidationHelper.createExecutionPlanIfValid(flowSpec).toJavaUtil();
if (dag.isPresent()) {
dagManagementStateStore.checkpointDag(dag.get());
+ // Delete adhoc flowSpecs from catalog after checkpointing the dag to
be worked on
+ if (!flowSpec.isScheduled()) {
+ dagManagementStateStore.removeFlowSpec(flowSpec);
Review Comment:
Is it the right place to remove flow spec? If the LaunchDagProc act fails, a
second retry will not be able to compile.
should we do it in LaunchDagTask conclude ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
