[ 
https://issues.apache.org/jira/browse/GOBBLIN-2110?focusedWorklogId=926367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926367
 ]

ASF GitHub Bot logged work on GOBBLIN-2110:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jul/24 16:04
            Start Date: 17/Jul/24 16:04
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4001:
URL: https://github.com/apache/gobblin/pull/4001#discussion_r1681318959


##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -1061,6 +1061,8 @@ public class ConfigurationKeys {
   // describes a comma separated list of non transient errors that may come in 
a gobblin job
   // e.g. "invalid_grant,CredentialStoreException"
   public static final String GOBBLIN_NON_TRANSIENT_ERRORS = 
"gobblin.errorMessages.nonTransientErrors";
+  // Key to store a comma-separated list of exception class names that should 
be retried
+  public static final String EXCEPTION_LIST_FOR_RETRY_CONFIG_KEY = 
"EXCEPTION_LIST_FOR_RETRY";

Review Comment:
   approving for now, but lets change the RHS to small case in the next commit 
and future prs





Issue Time Tracking
-------------------

    Worklog Id:     (was: 926367)
    Time Spent: 2.5h  (was: 2h 20m)

> Make retry_exception_predicate configurable in RetryerFactory
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-2110
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2110
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Aditya Pratap Singh
>            Priority: Minor
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Make retry_exception_predicate configurable in RetryerFactory



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to