arjun4084346 commented on code in PR #3999:
URL: https://github.com/apache/gobblin/pull/3999#discussion_r1681810288
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -58,7 +58,6 @@ protected void enforceDeadline(DagManagementStateStore
dagManagementStateStore,
dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_RUN_DEADLINE_EXCEEDED);
dag.setMessage("Flow killed due to exceeding SLA of " +
flowFinishDeadline + " ms");
- dagManagementStateStore.checkpointDag(dag);
Review Comment:
i was "checkpointing" them because i was changing "flowEvent" and "message"
fields. but i realize these two fields are not persisted anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
