[
https://issues.apache.org/jira/browse/GOBBLIN-2114?focusedWorklogId=926530&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926530
]
ASF GitHub Bot logged work on GOBBLIN-2114:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 19:04
Start Date: 18/Jul/24 19:04
Worklog Time Spent: 10m
Work Description: AndyJiang99 commented on code in PR #4005:
URL: https://github.com/apache/gobblin/pull/4005#discussion_r1683347509
##########
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractorStatsTracker.java:
##########
@@ -306,6 +310,13 @@ public void onDecodeableRecord(int partitionIdx, long
readStartTime, long decode
if (logAppendTimestamp > 0 && (System.currentTimeMillis() -
logAppendTimestamp > recordLevelSlaMillis)) {
v.slaMissedRecordCount++;
}
+ // See context in GOBBLIN-2114
Review Comment:
Can you add the short description here instead of referencing the Gobblin
ticket? Since we have so many stats tracker here, it would be good to have a
short description so we know what we are tracking and going forward, we know
what we already have.
The naming for the variables might be more descriptive/understandable maybe
as appendDurationTime and creationDurationTime to describe that it is amount of
time taken between HDFS and when it was produced / appended. What do you think?
Issue Time Tracking
-------------------
Worklog Id: (was: 926530)
Time Spent: 20m (was: 10m)
> Add fields to show computed delta between consume and producer/append time
> respectively
> ---------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2114
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2114
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a follow up ticket of GOBBLIN-2093 to further adding more SLA metrics
> to compare
> 1. hdfs write time - producer time
> 2. hdfs write time - append time
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
