umustafi commented on code in PR #4002:
URL: https://github.com/apache/gobblin/pull/4002#discussion_r1683411053
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngineTest.java:
##########
@@ -54,7 +54,7 @@ public class DagProcessingEngineTest {
private DagManagementTaskStreamImpl dagManagementTaskStream;
private DagTaskStream dagTaskStream;
private DagProcFactory dagProcFactory;
- private static MostlyMySqlDagManagementStateStore dagManagementStateStore;
+ private static MostlyMySqlDagManagementStateStore
testDagManagementStateStore;
Review Comment:
This method wasn't compiling before but if I reference the static field
explicitly it works. It's static bc this same reference is used to instantiate
every `MockedDagTask`
```
public MockedDagTask(DagActionStore.DagAction dagAction, boolean isBad) {
super(dagAction, leaseObtainedStatus,
DagProcessingEngineTest.dagManagementStateStore);
this.isBad = isBad;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
