[
https://issues.apache.org/jira/browse/GOBBLIN-2111?focusedWorklogId=926546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926546
]
ASF GitHub Bot logged work on GOBBLIN-2111:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/24 19:58
Start Date: 18/Jul/24 19:58
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #4002:
URL: https://github.com/apache/gobblin/pull/4002#discussion_r1683411053
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagProcessingEngineTest.java:
##########
@@ -54,7 +54,7 @@ public class DagProcessingEngineTest {
private DagManagementTaskStreamImpl dagManagementTaskStream;
private DagTaskStream dagTaskStream;
private DagProcFactory dagProcFactory;
- private static MostlyMySqlDagManagementStateStore dagManagementStateStore;
+ private static MostlyMySqlDagManagementStateStore
testDagManagementStateStore;
Review Comment:
This method wasn't compiling before but if I reference the static field
explicitly it works. It's static bc this same reference is used to instantiate
every `MockedDagTask`
```
public MockedDagTask(DagActionStore.DagAction dagAction, boolean isBad) {
super(dagAction, leaseObtainedStatus,
DagProcessingEngineTest.dagManagementStateStore);
this.isBad = isBad;
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 926546)
Time Spent: 3h 20m (was: 3h 10m)
> Delete adhoc flowSpecs from FlowCatalog for DagProcEngine
> ---------------------------------------------------------
>
> Key: GOBBLIN-2111
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2111
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> DagProcessingEngine fails to remove adhoc flow specs from catalog after
> checkpointing the dag.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
