arjun4084346 commented on code in PR #3983:
URL: https://github.com/apache/gobblin/pull/3983#discussion_r1683522169
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -73,6 +75,7 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Pair<Optiona
// dag actions for each of those parallel job and in this scenario there
is no job status available.
// If the job status is not present, this job was never launched, submit
it now.
DagProcUtils.submitJobToExecutor(dagManagementStateStore, dagNode,
getDagId());
+
dagProcEngineMetrics.markDagActionsAct(DagActionStore.DagActionType.REEVALUATE,
true);
Review Comment:
how about all dag procs implement the above mentioned `getDagActionType`
method? looks like the same line can be used in many places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
