[
https://issues.apache.org/jira/browse/GOBBLIN-2120?focusedWorklogId=927271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927271
]
ASF GitHub Bot logged work on GOBBLIN-2120:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/24 17:05
Start Date: 24/Jul/24 17:05
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4010:
URL: https://github.com/apache/gobblin/pull/4010#issuecomment-2248507762
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4010?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 38.74%. Comparing base
[(`2ea9622`)](https://app.codecov.io/gh/apache/gobblin/commit/2ea96226cedbc8286952029101d8acb82cecadc7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`4dd4d51`)](https://app.codecov.io/gh/apache/gobblin/commit/4dd4d519c65088db77adf7441cdd3b8784958e0d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4010 +/- ##
=============================================
- Coverage 55.20% 38.74% -16.47%
+ Complexity 1650 1596 -54
=============================================
Files 319 388 +69
Lines 11808 15965 +4157
Branches 1205 1580 +375
=============================================
- Hits 6519 6186 -333
- Misses 4710 9283 +4573
+ Partials 579 496 -83
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4010?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 927271)
Time Spent: 20m (was: 10m)
> Mark DagActionsConclude metric correctly
> ----------------------------------------
>
> Key: GOBBLIN-2120
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2120
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Urmi Mustafi
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Mark dagActionsConclude as failed if the delete failed
--
This message was sent by Atlassian Jira
(v8.20.10#820010)