umustafi commented on code in PR #4014:
URL: https://github.com/apache/gobblin/pull/4014#discussion_r1702197248
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStoreWithDagNodesTest.java:
##########
@@ -79,6 +79,8 @@ public void testAddGetAndDeleteDag() throws Exception{
Dag<JobExecutionPlan> originalDag2 = DagTestUtils.buildDag("random_2",
456L);
DagManager.DagId dagId1 = DagManagerUtils.generateDagId(originalDag1);
DagManager.DagId dagId2 = DagManagerUtils.generateDagId(originalDag2);
+ originalDag1.getStartNodes().get(0).getValue().setCurrentGeneration(2);
Review Comment:
can we add one test where the dag uses the default generation and attempts
(1.0)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
