[
https://issues.apache.org/jira/browse/GOBBLIN-2123?focusedWorklogId=928617&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-928617
]
ASF GitHub Bot logged work on GOBBLIN-2123:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/24 04:25
Start Date: 03/Aug/24 04:25
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4013:
URL: https://github.com/apache/gobblin/pull/4013#discussion_r1702454087
##########
gobblin-runtime/src/main/java/org/apache/gobblin/service/monitoring/FlowStatusGenerator.java:
##########
@@ -41,7 +41,7 @@
@Slf4j
public class FlowStatusGenerator {
public static final List<String> FINISHED_STATUSES =
Lists.newArrayList(ExecutionStatus.FAILED.name(),
- ExecutionStatus.COMPLETE.name(), ExecutionStatus.CANCELLED.name());
+ ExecutionStatus.COMPLETE.name(), ExecutionStatus.CANCELLED.name(),
ExecutionStatus.PENDING_RETRY.name());
Review Comment:
Yea, we can actually make it work without PENDING_RETRY. That was the
approach in the 1st commit (sorry, it lost because I mistakenly force pushed
another squashed commit)
We can completely remove PENDING_RETRY. But in that approach, job's status
will be shown 'FAILED' between both the attempts,, Kip preferred
'PENDING_RETRY'...
Issue Time Tracking
-------------------
Worklog Id: (was: 928617)
Time Spent: 20m (was: 10m)
> create reevaluate dag action for jobs in state PENDING_RETRY
> ------------------------------------------------------------
>
> Key: GOBBLIN-2123
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2123
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
