arjun4084346 commented on code in PR #4016:
URL: https://github.com/apache/gobblin/pull/4016#discussion_r1704668286
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -236,7 +237,7 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
try {
this.dagManagementStateStore.addJobDagAction(flowGroup,
flowName, flowExecutionId, jobName, DagActionStore.DagActionType.REEVALUATE);
} catch (IOException e) {
- if (e.getCause() != null &&
isThrowableInstanceOf(e.getCause(), nonRetryableExceptions)) {
+ if (ExceptionUtils.isExceptionInstanceOf(e,
nonRetryableExceptions)) {
Review Comment:
yes, we only re try adding dag action for transient exceptions, so we want
it to throw exception, so it is retried. if it is not retryable, it should be
swallowed. so the condition looks correct to me...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
