arjun4084346 commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707876270
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup,
jobName);
String status =
jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
call to modifyStateIfRetryRequired is pushed to later in time (in code diff
it is being shown above the older position, but actually that code runs before
this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
