[
https://issues.apache.org/jira/browse/GOBBLIN-2127?focusedWorklogId=929205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-929205
]
ASF GitHub Bot logged work on GOBBLIN-2127:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Aug/24 21:10
Start Date: 07/Aug/24 21:10
Worklog Time Spent: 10m
Work Description: umustafi commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707915249
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup,
jobName);
String status =
jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
this bug is hard to follow can u comment why the state check was moved here
so it is not changed in the future
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup,
jobName);
String status =
jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
+
+ if (updatedJobStatus.getRight() == NewState.FINISHED &&
!retryRequired) {
+ // do not send event if retry is required, because it can alert
users to re-submit a job that is already set to be retried by GaaS
Review Comment:
helpful comment
Issue Time Tracking
-------------------
Worklog Id: (was: 929205)
Remaining Estimate: 0h
Time Spent: 10m
> do not emit GaaSObservabilityEvent when the job is marked to be retried
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2127
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2127
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
