Will-Lo opened a new pull request, #4020: URL: https://github.com/apache/gobblin/pull/4020
… with equal file depths Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2128 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): `SetPermissionCommitStep` has a bug where it does not handle paths with the same file depth appropriately. If directories of the same nested path have different permissions, they can lead to unknown behavior as the key equality is incorrect here and doesn't maintain both separate paths/permissions. The key comparator: ``` Long.compare(o1.chars().filter(ch -> ch == '/').count(), o2.chars().filter(ch -> ch == '/').count()) ``` should be replaced with: ``` Comparator.comparingInt((String o) -> o.split("/").length).thenComparing(o -> o) ``` Additionally, build the paths and permissions from the existing map instead of re-reading from FS to reduce FS calls and ensure consistency. Add a setting to disable this permission step with the configuration ``` gobblin.copy.manifestBased.enableSetPermissionPostPublish ``` ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Unit tests. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
