[
https://issues.apache.org/jira/browse/GOBBLIN-2128?focusedWorklogId=929620&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-929620
]
ASF GitHub Bot logged work on GOBBLIN-2128:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/24 21:52
Start Date: 09/Aug/24 21:52
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4020:
URL: https://github.com/apache/gobblin/pull/4020#issuecomment-2278799997
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4020?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 41.11%. Comparing base
[(`e501b62`)](https://app.codecov.io/gh/apache/gobblin/commit/e501b62ffe646885d8b33198737bc16d38c04ba3?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`e4be396`)](https://app.codecov.io/gh/apache/gobblin/commit/e4be3962819c13b466347b671cf20ecaeded55ac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 3 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4020 +/- ##
============================================
- Coverage 45.86% 41.11% -4.75%
+ Complexity 3257 2204 -1053
============================================
Files 707 480 -227
Lines 27865 20365 -7500
Branches 2796 2355 -441
============================================
- Hits 12779 8374 -4405
+ Misses 14008 11099 -2909
+ Partials 1078 892 -186
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4020?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 929620)
Time Spent: 20m (was: 10m)
> Set permission in Manifest distcp does not set all paths correctly
> ------------------------------------------------------------------
>
> Key: GOBBLIN-2128
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2128
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There's a bug in the treemap for `SetPermissionCommitStep` where paths of the
> equal file depth can be misassigned permissions due to an error in the
> Treemap initialization:
> {code:java}
> Long.compare(o1.chars().filter(ch -> ch == '/').count(), o2.chars().filter(ch
> -> ch == '/').count()) {code}
> Treats any key with the same depth as equal, this could lead to incorrect
> behavior when performing map operations in this map.
> We want to rearrange this so that the comparator also compares the source
> string.
> Additionally, build off the map from the same file permissions as the
> ancestor tree in copyable file so that it can stay consistent permission
> reading and reduce FS calls.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
