arjun4084346 commented on code in PR #4023:
URL: https://github.com/apache/gobblin/pull/4023#discussion_r1712700291
##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -412,20 +386,19 @@ protected void logNewlyScheduledJob(JobDetail job,
Trigger trigger) {
/**
* Unschedule and delete a job.
+ * Returns true is job was scheduled and is successfully unscheduled, false
otherwise
*
* @param jobName Job name
* @throws JobException when there is anything wrong unschedule the job
*/
- public void unscheduleJob(String jobName)
+ public boolean unscheduleJob(String jobName)
Review Comment:
this is the only code (non-codestyle) change in this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
