[ 
https://issues.apache.org/jira/browse/GOBBLIN-2129?focusedWorklogId=929725&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-929725
 ]

ASF GitHub Bot logged work on GOBBLIN-2129:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/24 03:05
            Start Date: 12/Aug/24 03:05
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4023:
URL: https://github.com/apache/gobblin/pull/4023#discussion_r1713131248


##########
gobblin-runtime/src/main/java/org/apache/gobblin/scheduler/JobScheduler.java:
##########
@@ -412,20 +411,19 @@ protected void logNewlyScheduledJob(JobDetail job, 
Trigger trigger) {
 
   /**
    * Unschedule and delete a job.
+   * Returns true is job was scheduled and is successfully unscheduled, false 
otherwise
    *
    * @param jobName Job name
    * @throws JobException when there is anything wrong unschedule the job
    */
-  public void unscheduleJob(String jobName)
+  public boolean unscheduleJob(String jobName)

Review Comment:
   oh, btw problem is that the job does not exist in 
GobblinServiceJobScheduler::scheduledFlowSpecs
   not in JobScheduler::scheduledJobs





Issue Time Tracking
-------------------

    Worklog Id:     (was: 929725)
    Time Spent: 40m  (was: 0.5h)

> do not throw log polluting exceptions in GobblinServiceJobScheduler
> -------------------------------------------------------------------
>
>                 Key: GOBBLIN-2129
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2129
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to