[
https://issues.apache.org/jira/browse/GOBBLIN-2131?focusedWorklogId=931006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931006
]
ASF GitHub Bot logged work on GOBBLIN-2131:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Aug/24 17:14
Start Date: 20/Aug/24 17:14
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4024:
URL: https://github.com/apache/gobblin/pull/4024#discussion_r1723675262
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -146,15 +149,40 @@ protected void initializeMonitor() {
throw new RuntimeException(String.format("Unable to retrieve dagActions
from the dagActionStore while "
+ "initializing the %s",
DagActionStoreChangeMonitor.class.getCanonicalName()), e);
}
- // TODO: make this multi-threaded to add parallelism
+ ThreadFactory threadFactory =
getThreadFactoryWithUncaughtExceptionHandler();
+
+ final ExecutorService executorService =
Executors.newFixedThreadPool(ConfigUtils.getInt(this.config,
ConfigurationKeys.DAG_ACTION_STORE_MONITOR_EXECUTOR_THREADS, 5), threadFactory);
Review Comment:
hey, you can use `ExecutorUtils.newThreadFactory()` to get thread factory.
it also has exception handler
https://github.com/apache/gobblin/blob/master/gobblin-utility/src/main/java/org/apache/gobblin/util/ExecutorsUtils.java#L76
Issue Time Tracking
-------------------
Worklog Id: (was: 931006)
Time Spent: 2h (was: 1h 50m)
> process all dag actions by multiple threads on initialization
> -------------------------------------------------------------
>
> Key: GOBBLIN-2131
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2131
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> process all dag actions by multiple threads on initialization
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
