[
https://issues.apache.org/jira/browse/GOBBLIN-2141?focusedWorklogId=931398&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931398
]
ASF GitHub Bot logged work on GOBBLIN-2141:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/24 21:14
Start Date: 22/Aug/24 21:14
Worklog Time Spent: 10m
Work Description: Will-Lo opened a new pull request, #4036:
URL: https://github.com/apache/gobblin/pull/4036
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2141
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Simulation mode in retention relies on the usage of MockTrash, which doesn't
always reflect the details of moving trash to certain spaces that the actual
Trash class implements, and some of the details of which folders it creates.
The mock trash class also makes it difficult to simulate behaviors on any
classes that extend a part of Trash class since they would have to create a
corresponding mock class, which makes the purpose of the simulate mode moot
since it's not actually simulating the live behavior.
We want to have an opt-in configuration (to not break existing simulation
jobs of retention) to have the Trash class log out which files it is moving to
its trash location.
If a user has `gobblin.retention.simulate=true` and
`gobblin.trash.simulate.actual.trash=true`, it will simulate without using the
MockTrash class
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Unit tests
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 931398)
Remaining Estimate: 0h
Time Spent: 10m
> Enable simulate retention jobs using the actual trash class instead of
> mocktrash
> --------------------------------------------------------------------------------
>
> Key: GOBBLIN-2141
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2141
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Simulation mode in retention relies on the usage of MockTrash, which doesn't
> always reflect the details of moving trash to certain spaces that the actual
> Trash class implements, and some of the details of which folders it creates.
> The mock trash class also makes it difficult to simulate behaviors on any
> classes that extend a part of Trash class since they would have to create a
> corresponding mock class, which makes the purpose of the simulate mode moot
> since it's not actually simulating the live behavior.
> We want to have an opt-in configuration (to not break existing simulation
> jobs of retention) to have the Trash class log out which files it is moving
> to its trash location.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
