[
https://issues.apache.org/jira/browse/GOBBLIN-2142?focusedWorklogId=931685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931685
]
ASF GitHub Bot logged work on GOBBLIN-2142:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/24 08:53
Start Date: 26/Aug/24 08:53
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4037:
URL: https://github.com/apache/gobblin/pull/4037#discussion_r1730924866
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtils.java:
##########
@@ -219,6 +219,7 @@ public static Set<DagNode<JobExecutionPlan>>
getNext(Dag<JobExecutionPlan> dag)
switch (failureOption) {
case FINISH_RUNNING:
return new HashSet<>();
+ // todo - FINISH_ALL_POSSIBLE should probably `continue` not `break`
Review Comment:
this is a legacy code and very important. I would like to not touch it in
this PR because this PR is addressing an alarming issue and cannot afford
introducing issue.
It is also not related to this PR work, so will fix it in a separate PR
Issue Time Tracking
-------------------
Worklog Id: (was: 931685)
Time Spent: 1h 10m (was: 1h)
> find if the dag is running or not correctly
> -------------------------------------------
>
> Key: GOBBLIN-2142
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2142
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
