[
https://issues.apache.org/jira/browse/GOBBLIN-2144?focusedWorklogId=932053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932053
]
ASF GitHub Bot logged work on GOBBLIN-2144:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Aug/24 21:21
Start Date: 27/Aug/24 21:21
Worklog Time Spent: 10m
Work Description: phet opened a new pull request, #4039:
URL: https://github.com/apache/gobblin/pull/4039
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2144
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Whereas the `AbstractJobLauncher`, used by Gobblin-on-MR runs the entire job
end-to-end, this Gobblin-on-Temporal activity solely generates WUs w/o actually
processing them. Thus it's far too early to clean anything up in the
temp/staging dirs (e.g. task-staging and task-output, used by writers and the
commit step).
Even worse, depending upon config, doing cleanup nonetheless could
destabilize other job executions, when those share this same temp/staging area.
Such cross-job "action-at-a-distance" is unpredictable and especially
challenging even to diagnose.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
`./gradlew build` successful
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 932053)
Remaining Estimate: 0h
Time Spent: 10m
> Prevent Gobblin-on-Temporal WU Generation from inadvertently cleaning up
> temp/staging dirs
> ------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2144
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2144
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> WU Generation is far too early in a job to have anything to even cleanup in
> the temp/staging dir (e.g. for task-staging and task-output). unfortunately,
> depending on config, doing this anyway could impact other job execs sharing
> the same temp/staging area.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
