[
https://issues.apache.org/jira/browse/GOBBLIN-2143?focusedWorklogId=932480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932480
]
ASF GitHub Bot logged work on GOBBLIN-2143:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/24 18:55
Start Date: 29/Aug/24 18:55
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4038:
URL: https://github.com/apache/gobblin/pull/4038#discussion_r1736936615
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagStateStoreWithDagNodes.java:
##########
@@ -38,7 +38,7 @@ public interface DagStateStoreWithDagNodes extends
DagStateStore {
* Updates the {@link Dag.DagNode} with the provided value.
* Returns 1 if the dag node is updated successfully, 0 otherwise
*/
- int updateDagNode(Dag.DagNode<JobExecutionPlan> dagNode) throws IOException;
+ boolean updateDagNode(Dag.DagNode<JobExecutionPlan> dagNode) throws
IOException;
Review Comment:
good change. need to update javadoc now
Issue Time Tracking
-------------------
Worklog Id: (was: 932480)
Time Spent: 0.5h (was: 20m)
> handle concurrent ReevaluateDagProc for cancelled dag nodes correctly
> ---------------------------------------------------------------------
>
> Key: GOBBLIN-2143
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2143
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
