phet commented on code in PR #4038:
URL: https://github.com/apache/gobblin/pull/4038#discussion_r1736936615
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagStateStoreWithDagNodes.java:
##########
@@ -38,7 +38,7 @@ public interface DagStateStoreWithDagNodes extends
DagStateStore {
* Updates the {@link Dag.DagNode} with the provided value.
* Returns 1 if the dag node is updated successfully, 0 otherwise
*/
- int updateDagNode(Dag.DagNode<JobExecutionPlan> dagNode) throws IOException;
+ boolean updateDagNode(Dag.DagNode<JobExecutionPlan> dagNode) throws
IOException;
Review Comment:
good change. need to update javadoc now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
