arjun4084346 commented on code in PR #4043:
URL: https://github.com/apache/gobblin/pull/4043#discussion_r1739811047
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -60,7 +60,9 @@ protected void enforceDeadline(DagManagementStateStore
dagManagementStateStore,
DagProcUtils.cancelDagNode(dagNodeToCancel, dagManagementStateStore);
}
- dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_RUN_DEADLINE_EXCEEDED);
+ DagProcUtils.setAndEmitFlowEvent(eventSubmitter, dag,
TimingEvent.FlowTimings.FLOW_CANCELLED);
Review Comment:
job level cancellation event is emitted from inside
DagProcUtils.cancelDagNode
and then when Reevaluate dag proc is created because of this event, and that
Reevaluate calls
DagProcUtils.setAndEmitFlowEvent()
I think I've seen dag status being set to CANCELLED when it misses deadline.
Are you not seeing FLOW CANCELLED event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
