[
https://issues.apache.org/jira/browse/GOBBLIN-2147?focusedWorklogId=932804&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932804
]
ASF GitHub Bot logged work on GOBBLIN-2147:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Sep/24 15:43
Start Date: 01/Sep/24 15:43
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4044:
URL: https://github.com/apache/gobblin/pull/4044#issuecomment-2323401884
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4044?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 41.14%. Comparing base
[(`444f266`)](https://app.codecov.io/gh/apache/gobblin/commit/444f2664be7fb3a44342cc481aaefb46542e8ede?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`1299752`)](https://app.codecov.io/gh/apache/gobblin/commit/1299752d1bc20f79f615e2bc90660a7ec4b4fbd1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4044 +/- ##
============================================
+ Coverage 38.79% 41.14% +2.35%
- Complexity 1599 2204 +605
============================================
Files 388 480 +92
Lines 15998 20360 +4362
Branches 1585 2355 +770
============================================
+ Hits 6207 8378 +2171
- Misses 9293 11090 +1797
- Partials 498 892 +394
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4044?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 932804)
Time Spent: 20m (was: 10m)
> Add lookback time property in PartitionedFileSource
> ---------------------------------------------------
>
> Key: GOBBLIN-2147
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2147
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> All FileBasedSource implementations should have config for lookback time.
>
> Currently
> FileBasedSources look for data since the time set by
> `conversion.min.watermark` and time granularity is decided by the lowest time
> denomination. that denomination in many cases, including this one, is 1 second
> (determined by
> |gobblin.flow.input.dataset.descriptor.partition.pattern|yyyy-MM-dd_HH_mm_ss|
>
> It is an extremely abusive way to find workunits.
> Let's enable these jobs to use lookback time configs like several other
> dataset finders do.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
