[
https://issues.apache.org/jira/browse/GOBBLIN-2146?focusedWorklogId=932775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932775
]
ASF GitHub Bot logged work on GOBBLIN-2146:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Aug/24 16:40
Start Date: 31/Aug/24 16:40
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4043:
URL: https://github.com/apache/gobblin/pull/4043#discussion_r1739811047
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -60,7 +60,9 @@ protected void enforceDeadline(DagManagementStateStore
dagManagementStateStore,
DagProcUtils.cancelDagNode(dagNodeToCancel, dagManagementStateStore);
}
- dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_RUN_DEADLINE_EXCEEDED);
+ DagProcUtils.setAndEmitFlowEvent(eventSubmitter, dag,
TimingEvent.FlowTimings.FLOW_CANCELLED);
Review Comment:
job level cancellation event is emitted from inside
DagProcUtils.cancelDagNode
and then when Reevaluate dag proc is created because of this event, and that
Reevaluate calls
DagProcUtils.setAndEmitFlowEvent()
I think I've seen dag status being set to CANCELLED when it misses deadline.
Are you not seeing FLOW CANCELLED event?
Issue Time Tracking
-------------------
Worklog Id: (was: 932775)
Time Spent: 40m (was: 0.5h)
> GaaS SLA flow cancellation is not emitting a flow event which blocks incoming
> jobs
> ----------------------------------------------------------------------------------
>
> Key: GOBBLIN-2146
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2146
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> GaaS is not emitting flow level events when SLA killing jobs. This needs to
> be fixed otherwise the flow status reporting becomes incorrect.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
