[
https://issues.apache.org/jira/browse/GOBBLIN-2150?focusedWorklogId=933269&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933269
]
ASF GitHub Bot logged work on GOBBLIN-2150:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/24 23:23
Start Date: 04/Sep/24 23:23
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4048:
URL: https://github.com/apache/gobblin/pull/4048#discussion_r1744613759
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
Review Comment:
these are testing `DagProcUtils`... do we have a plan separately to rename
this test class?
##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/DagManagerUtilsTest.java:
##########
@@ -109,15 +118,19 @@ public void testIsDagFinishedTwoNodes() throws
URISyntaxException {
setJobStatuses(dag, Arrays.asList(COMPLETE, PENDING));
Assert.assertFalse(DagProcUtils.isDagFinished(dag));
+ Assert.assertEquals(TimingEvent.FlowTimings.FLOW_RUNNING,
DagProcUtils.calcFlowStatus(dag));
Review Comment:
it took me a minute to realize you were repurposing the tests you just wrote
for `isDagFinished` (which are very good BTW). as a minor suggestion, consider
renaming all of the test methods to reflect the dual purpose. e.g. something
like, `testFlowStatusPlusIsDagFinishedTwoNodes`
Issue Time Tracking
-------------------
Worklog Id: (was: 933269)
Remaining Estimate: 0h
Time Spent: 10m
> calculate flow status based on all the jobs of a dag, not just the last one
> ---------------------------------------------------------------------------
>
> Key: GOBBLIN-2150
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2150
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
