[
https://issues.apache.org/jira/browse/GOBBLIN-2151?focusedWorklogId=934291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934291
]
ASF GitHub Bot logged work on GOBBLIN-2151:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 15:28
Start Date: 11/Sep/24 15:28
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1754961673
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -165,7 +165,8 @@ public Optional<Dag<JobExecutionPlan>>
validateAndHandleConcurrentExecution(Conf
}
addFlowExecutionIdIfAbsent(flowMetadata, jobExecutionPlanDag);
- if (isExecutionPermitted(flowGroup, flowName, allowConcurrentExecution)) {
+ if (isExecutionPermitted(flowGroup, flowName,
+
Long.parseLong(flowMetadata.get(TimingEvent.FlowEventConstants.FLOW_EXECUTION_ID_FIELD)),
allowConcurrentExecution)) {
Review Comment:
i totally did not understand what you mean by "this", "others"
Issue Time Tracking
-------------------
Worklog Id: (was: 934291)
Time Spent: 3.5h (was: 3h 20m)
> ignore flows that are running beyond job start and flow finish deadline
> -----------------------------------------------------------------------
>
> Key: GOBBLIN-2151
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2151
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
