phet commented on code in PR #4050:
URL: https://github.com/apache/gobblin/pull/4050#discussion_r1755294130
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java:
##########
@@ -217,13 +219,21 @@ static boolean isFlowBeforeThisExecutionRunning(String
flowGroup, String flowNam
}
for (FlowStatus flowStatus : flowStatusList) {
+ ExecutionStatus flowExecutionStatus =
flowStatus.getFlowExecutionStatus();
if (flowStatus.getFlowExecutionId() == flowExecutionId) {
// a duplicate call to this method indicate that the prior caller of
this method could not complete the required action,
// so we ignore any flow status for the current execution to give the
caller another chance to complete them
+ // but this should be rate, so lets log it
+ if (flowExecutionStatus == COMPILED) {
+ log.info("A previous execution with the same flowExecutionId found
{}. Previous execution may not be "
+ + "successfully submitted.", flowStatus);
+ } else if (flowExecutionStatus == RUNNING) {
+ log.error("A previous execution with the same flowExecutionId found
{}. This is a rare case of previous "
+ + "execution getting submitted but then LaunchDagProc failed to
complete the lease", flowStatus);
+ }
Review Comment:
unexpected though it may be, to avoid any other status slipping through the
cracks, let's log all others as `.warn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
