arjun4084346 commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1755525954
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -159,9 +164,12 @@ private void onJobFinish(DagManagementStateStore
dagManagementStateStore, Dag.Da
dag.setMessage("Flow failed because job " + jobName + " failed");
dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_FAILED);
dagManagementStateStore.getDagManagerMetrics().incrementExecutorFailed(dagNode);
+ DagProcUtils.sendSkippedEventForDependentJobs(dag, dagNode);
Review Comment:
yes (d) needs to be removed. in a draft version, i was emitting skipped
events only for the child jobs not for all the dependent jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
