Will-Lo commented on code in PR #4030:
URL: https://github.com/apache/gobblin/pull/4030#discussion_r1755527804


##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnHelixUtils.java:
##########
@@ -199,6 +203,18 @@ public static void setYarnClassPath(Config config, 
Configuration yarnConfigurati
     }
   }
 
+  public static Path getJarPathCacheAndCleanIfNeeded(Config config, FileSystem 
fs) throws IOException {

Review Comment:
   I set retainKLatestCachePaths to return false if any deletion failed rather 
than true iff there were any deletions, but this was a good idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to