[
https://issues.apache.org/jira/browse/GOBBLIN-2155?focusedWorklogId=934765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934765
]
ASF GitHub Bot logged work on GOBBLIN-2155:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/24 18:24
Start Date: 13/Sep/24 18:24
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4054:
URL: https://github.com/apache/gobblin/pull/4054#discussion_r1759293079
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/DirDeletionResult.java:
##########
@@ -34,4 +35,9 @@
public class DirDeletionResult {
@NonNull private Map<String, Boolean> successesByDirPath;
+
+ // Needed to support jackson (de)serialization
Review Comment:
please add the exception (given in the PR's desc) as a code comment
Issue Time Tracking
-------------------
Worklog Id: (was: 934765)
Remaining Estimate: 0h
Time Spent: 10m
> DeleteWorkDirsActivity needs to serialize the empty result
> ----------------------------------------------------------
>
> Key: GOBBLIN-2155
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2155
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently there is a bug in Temporal when there are no work directories to
> delete, e.g. non hdfs sink jobs.
> {code:java}
> Caused by: io.temporal.common.converter.DataConverterException:
> com.fasterxml.jackson.databind.JsonMappingException: successesByDirPath is
> marked non-null but is null
> at [Source: (byte[])"{"successesByDirPath":null}"; line: 1, column: 23]
> (through reference chain:
> org.apache.gobblin.temporal.ddm.work.DirDeletionResult["successesByDirPath"])
> at
> io.temporal.common.converter.JacksonJsonPayloadConverter.fromData(JacksonJsonPayloadConverter.java:101)
> at
> io.temporal.common.converter.DefaultDataConverter.fromPayload(DefaultDataConverter.java:145)
> {code}
> We need to fix the empty result of DeleteWorkDirsActivity to support this
> scenario with a serializable result and add tests.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
