phet commented on code in PR #4056:
URL: https://github.com/apache/gobblin/pull/4056#discussion_r1759607239
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTable.java:
##########
@@ -213,7 +215,10 @@ public DatasetDescriptor getDatasetDescriptor(FileSystem
fs) {
protected void registerIcebergTable(TableMetadata srcMetadata, TableMetadata
dstMetadata) {
if (dstMetadata != null) {
// use current destination metadata as 'base metadata' and source as
'updated metadata' while committing
- this.tableOps.commit(dstMetadata,
srcMetadata.replaceProperties(dstMetadata.properties()));
+ Map<String, String> combinedMetadataProperties = Maps.newHashMap();
+ combinedMetadataProperties.putAll(dstMetadata.properties());
+ combinedMetadataProperties.putAll(srcMetadata.properties());
Review Comment:
please add a comment that captures the reasoning behind overshadowing dest
with src
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
