phet commented on code in PR #4033:
URL: https://github.com/apache/gobblin/pull/4033#discussion_r1775761769
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -67,4 +68,6 @@ protected String getDatasetDescriptorPlatform() {
}
protected abstract TableOperations createTableOperations(TableIdentifier
tableId);
+
+ protected abstract Table loadTableInstance(TableIdentifier tableId);
Review Comment:
this change is backwards-*IN*compatible, but I don't see any easy way around
that. clearly some iceberg invocations, like `replacePartitions` require the
`Table`, rather than the `TableOperations` or the `Catalog`, so there doesn't
seem to be an alternative route - `Table` use is essential.
that said, perhaps this PR should show the motivation for adding this
method, by including code *calling* it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
