[
https://issues.apache.org/jira/browse/GOBBLIN-2138?focusedWorklogId=936453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936453
]
ASF GitHub Bot logged work on GOBBLIN-2138:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/24 18:28
Start Date: 25/Sep/24 18:28
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4033:
URL: https://github.com/apache/gobblin/pull/4033#discussion_r1775761769
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -67,4 +68,6 @@ protected String getDatasetDescriptorPlatform() {
}
protected abstract TableOperations createTableOperations(TableIdentifier
tableId);
+
+ protected abstract Table loadTableInstance(TableIdentifier tableId);
Review Comment:
this change is backwards-*IN*compatible, but I don't see any easy way around
that. I see that some iceberg invocations, like `replacePartitions` require
the `Table`, rather than the `TableOperations` or the `Catalog`, so I don't see
an alternative - the `Table` is essential.
that said, perhaps this PR should show the motivation for adding this
method, by including code *calling* it
Issue Time Tracking
-------------------
Worklog Id: (was: 936453)
Time Spent: 20m (was: 10m)
> Add a loadTable() api in BaseIcebergCatalog
> -------------------------------------------
>
> Key: GOBBLIN-2138
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2138
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
